Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an otelcol.processor.span component #4449

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Add an otelcol.processor.span component #4449

merged 3 commits into from
Jul 24, 2023

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Jul 14, 2023

PR Description

This is based on the upstream span processor.

Which issue(s) this PR fixes

Fixes #2612

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@ptodev ptodev requested review from a team and clayton-cornell as code owners July 14, 2023 07:41
@ptodev ptodev linked an issue Jul 14, 2023 that may be closed by this pull request
Flow: otelcol.processor.spanprocessor component #2612
Closed
clayton-cornell
clayton-cornell reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment to add a canonical URL in the metadata for the new topic.

All other changes are template level and will be done at a later date.

ptodev and others added 2 commits July 24, 2023 15:40
@ptodev
Add an otelcol.processor.span component
06799e2
@ptodev @clayton-cornell
Add canonical link to docs
ccb753f 
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@ptodev ptodev force-pushed the 2612-flow-otelcolprocessorspanprocessor-component branch from 773059a to ccb753f Compare July 24, 2023 12:40
@ptodev ptodev requested a review from clayton-cornell July 24, 2023 13:07
@ptodev
Copy link
Contributor Author

ptodev commented Jul 24, 2023

I will also need to update Otel's docs to indicate that the Grafana Agent distribution supports this processor.
@jpkrohling - I suppose I should only update Collector's docs after we have an Agent release version which includes this processor? Or would it be ok to update the docs as soon as we merge to our main branch?

mattdurham
mattdurham approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clayton-cornell
clayton-cornell approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptodev ptodev merged commit 5fa2808 into main Jul 24, 2023
@ptodev ptodev deleted the 2612-flow-otelcolprocessorspanprocessor-component branch July 24, 2023 21:04
@ptodev ptodev mentioned this pull request Jul 24, 2023
Merged
clayton-cornell added a commit that referenced this pull request Aug 14, 2023
@ptodev @clayton-cornell
Add an otelcol.processor.span component (#4449)
7a00d99 
* Add an otelcol.processor.span component

* Add canonical link to docs

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Add the new processor to all.go

---------

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell added a commit that referenced this pull request Aug 14, 2023
@ptodev @clayton-cornell
Add an otelcol.processor.span component (#4449)
40c7f9e 
* Add an otelcol.processor.span component

* Add canonical link to docs

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Add the new processor to all.go

---------

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clayton-cornell clayton-cornell clayton-cornell approved these changes

@mattdurham mattdurham mattdurham approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flow: otelcol.processor.spanprocessor component
3 participants
@ptodev @mattdurham @clayton-cornell