build: do not produce Windows binaries with netgo build tags #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.19 adds Windows support for the native Go network stack, but doesn't include support for resolving DNS short names. Other projects, including Prometheus, have updated their build process to exclude the netgo build tags when producing Windows binaries to work around this behavior. Fixes grafana#4665.
rfratto
force-pushed
the
remove-netgo-windows
branch
from
91c6de1 to
3f89af3
Compare
ptodev
reviewed
Aug 1, 2023
| dist/grafana-agent-darwin-arm64: GOOS := darwin | ||
| dist/grafana-agent-darwin-arm64: GOARCH := arm64 | ||
| dist/grafana-agent-darwin-arm64: generate-ui | ||
| $(PACKAGING_VARS) AGENT_BINARY=$@ $(MAKE) -f $(PARENT_MAKEFILE) agent | ||
|
|
||
| # NOTE(rfratto): do not use netgo when building Windows binaries, which | ||
| # prevents DNS short names from being resovable. See grafana/agent#4665. |
There was a problem hiding this comment.
Do we need to add a TODO to revert this change when the underlying Go issue is resolved?
golang/go#57757
There was a problem hiding this comment.
I don't think that's the same issue, is it? I don't see any mention of the hosts file in the issue or the Prometheus issue.
There was a problem hiding this comment.
I added a generic TODO comment, since I don't think this is the same issue.
There was a problem hiding this comment.
Ah yes, I think you're right and it's not the same issue. But it's probably another issue which needs to be resolved before we use netgo on windows. Anyway, thank you for adding the TODO.
ptodev
approved these changes
Aug 1, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
Go 1.19 adds Windows support for the native Go network stack, but doesn't include support for resolving DNS short names. Other projects, including Prometheus, have updated their build process to exclude the netgo build tags when producing Windows binaries to work around this behavior. Fixes #4665.
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
Go 1.19 adds Windows support for the native Go network stack, but doesn't include support for resolving DNS short names. Other projects, including Prometheus, have updated their build process to exclude the netgo build tags when producing Windows binaries to work around this behavior. Fixes #4665.
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.19 adds Windows support for the native Go network stack, but doesn't include support for resolving DNS short names.
Other projects, including Prometheus, have updated their build process to exclude the netgo build tags when producing Windows binaries to work around this behavior.
Fixes #4665