Add missing shared link syntax #5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
the
type/docs
tpaschalis
reviewed
Sep 11, 2023
| @@ -135,7 +135,7 @@ Name | Type | Description | Default | Required | |||
|
|
|||
| ### output block | |||
|
|
|||
| {{< docs/shared lookup="flow/reference/components/output-block-metrics.md" source="agent" >}} | |||
| {{< docs/shared lookup="flow/reference/components/output-block-metrics.md" source="agent" version="<AGENT VERSION>" >}} | |||
There was a problem hiding this comment.
I see a few other occurrences of this in case we want to bundle them here.
$ grep -r "docs/shared lookup" | grep -v "VERSION"
docs/developer/writing-flow-component-documentation.md:{{< docs/shared lookup="flow/stability/beta.md" source="agent" >}}
docs/developer/writing-flow-component-documentation.md:{{< docs/shared lookup="flow/stability/experimental.md" source="agent" >}}
docs/sources/flow/reference/components/discovery.consulagent.md:{{< docs/shared lookup="flow/reference/components/tls-config-block.md" source="agent" >}}
docs/sources/flow/reference/components/otelcol.connector.servicegraph.md:{{< docs/shared lookup="flow/stability/experimental.md" source="agent" >}}
docs/sources/flow/reference/components/otelcol.connector.servicegraph.md:{{< docs/shared lookup="flow/reference/components/output-block-metrics.md" source="agent" >}}
There was a problem hiding this comment.
I can add them into the PR...
DONE
tpaschalis
approved these changes
Sep 11, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The shared link syntax was missing the
version="<AGENT VERSION>"part. This PR adds it to the topic.Parent PR is: #5008
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist