Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire up scrape_classic_histogram for the prometheus converter #5336

Merged
merged 2 commits into from
Sep 29, 2023
Merged

wire up scrape_classic_histogram for the prometheus converter #5336

merged 2 commits into from
Sep 29, 2023

Conversation

erikbaranowski
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@erikbaranowski
wire up scrape_classic_histogram for the prometheus converter
eaafc04 
Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
@erikbaranowski erikbaranowski requested a review from a team as a code owner September 29, 2023 13:55
tpaschalis
tpaschalis approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@erikbaranowski
put back in properties to false for scrape
77d7c23 
Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
@erikbaranowski erikbaranowski enabled auto-merge (squash) September 29, 2023 14:03
@erikbaranowski erikbaranowski merged commit 9404e2f into main Sep 29, 2023
6 checks passed
@erikbaranowski erikbaranowski deleted the converter-scrape_classic_histogram branch September 29, 2023 14:05
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tpaschalis tpaschalis tpaschalis approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikbaranowski @tpaschalis