Add a otelcol.processor.transform component #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
force-pushed
the
2910-otel-transformprocessor
branch
from
70a9baf to
d437f6d
Compare
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
ptodev
force-pushed
the
2910-otel-transformprocessor
branch
3 times, most recently
from
4bae072 to
a1d8caa
Compare
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
ptodev
force-pushed
the
2910-otel-transformprocessor
branch
from
a1d8caa to
95cec8f
Compare
mattdurham
reviewed
Oct 2, 2023
|
|
||
| input["error_mode"] = args.ErrorMode | ||
|
|
||
| if len(args.TraceStatements) > 0 { |
There was a problem hiding this comment.
Could this be simplified by removing the len check? Your checking for nil in the convert itself.
There was a problem hiding this comment.
Sometimes in the Collector config the behaviour is different even if none of the underlying config is set. E.g. I think this will enable both grpc and http receivers:
receivers:
otlp:
protocols:
grpc:
http:
But I think this will enable only http:
receivers:
otlp:
protocols:
http:
In the case of this component, I think the behaviour would be the same, but I'd still want to refrain from setting this unless we want this field to be used with its default values.
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
thampiotr
approved these changes
Oct 3, 2023
| LogStatements contextStatementsSlice `river:"log_statements,block,optional"` | ||
|
|
||
| // Output configures where to send processed data. Required. | ||
| Output *otelcol.ConsumerArguments `river:"output,block"` |
There was a problem hiding this comment.
Nit: If this is required, should we make it a struct instead of a pointer?
There was a problem hiding this comment.
I'd like to keep it consistent between all otelcol components. Not sure why it's a pointer tbh. Maybe to avoid extra copies? @rfratto, do you happen to know why it was originally made this way?
clayton-cornell
approved these changes
Oct 3, 2023
clayton-cornell
added
the
type/docs
tpaschalis
pushed a commit
to tpaschalis/agent
that referenced
this pull request
Oct 4, 2023
* Add a otelcol.processor.transform component --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR ports the transform processor to Flow.
Which issue(s) this PR fixes
Fixes #2910
Notes to the Reviewer
When writing flow docs, usually we avoid linking to the documentation of the underlying Otel component so that we don't confuse users with yaml configs which don't apply for the Agent. In this case I had to link to the Otel docs quite a lot. I tried to only link to places where it made sense, and to sections where there isn't any yaml config which could confuse a reader.
PR Checklist