Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw strings for regexes in otelcol docs #5636

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Oct 27, 2023

Usability improvement - we can now use raw strings in River configs, so I'm updating the otelcol docs. It'll make an especially big difference to otelcol.processor.transform.

@ptodev ptodev requested review from a team and clayton-cornell as code owners October 27, 2023 19:15
@ptodev ptodev force-pushed the ptodev/recommend-raw-strings branch from 5f1d61c to de18652 Compare October 27, 2023 19:25
Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A lot of this river could be run through the formatter for consistency but in terms of swapping to backticks it looks good.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Oct 30, 2023
ptodev and others added 3 commits October 30, 2023 19:16
…form.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…form.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…form.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@ptodev ptodev merged commit 7fc7653 into main Oct 31, 2023
8 checks passed
@ptodev ptodev deleted the ptodev/recommend-raw-strings branch October 31, 2023 21:11
hainenber pushed a commit to hainenber/agent that referenced this pull request Nov 1, 2023
* Use raw strings for regexes in docs

* Update note in beginning of doc

---------

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants