-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use raw strings for regexes in otelcol docs #5636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
force-pushed
the
ptodev/recommend-raw-strings
branch
from
October 27, 2023 19:25
5f1d61c
to
de18652
Compare
erikbaranowski
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A lot of this river could be run through the formatter for consistency but in terms of swapping to backticks it looks good.
4 tasks
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.transform.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
Docs Squad label across all Grafana Labs repos
label
Oct 30, 2023
…form.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…form.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…form.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
approved these changes
Oct 31, 2023
hainenber
pushed a commit
to hainenber/agent
that referenced
this pull request
Nov 1, 2023
* Use raw strings for regexes in docs * Update note in beginning of doc --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
github-actions
bot
added
the
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
label
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
type/docs
Docs Squad label across all Grafana Labs repos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usability improvement - we can now use raw strings in River configs, so I'm updating the otelcol docs. It'll make an especially big difference to
otelcol.processor.transform
.