feat(pyroscope/scrape): add support for configuring CPU profile's duration scraped by pyroscope.scrape.
#6827
Conversation
…ation scraped by `pyroscope.scrape`. Signed-off-by: hainenber <dotronghai96@gmail.com>
| automatically added to requests. The `seconds` used will be, by default to `scrape_interval - 1` | ||
| , or `profiling_duration` if specified. |
There was a problem hiding this comment.
| automatically added to requests. The `seconds` used will be, by default to `scrape_interval - 1` | |
| , or `profiling_duration` if specified. | |
| automatically added to requests. | |
| The default value for the `seconds` query parameter is `scrape_interval - 1`. | |
| If you set `profiling_duration`, then `seconds` is assigned the same value as `profiling_duration`. | |
| For example, if you set `scrape_interval` to `"15s"`, then `seconds` defaults to `14s`. | |
| If you set `profiling_duration` to `16s`, then `seconds is set to `16s` regardless of the `scrape_interval` value. |
This probably isn't the final wording. I'm trying to understand the logic first... is this close?
There was a problem hiding this comment.
Yes, that's the correct logic. I think your suggestion is sufficient but alas, there's a missing backtick here :D
There was a problem hiding this comment.
I've updated the suggestion a little. I fixed the missing backtick, and adjusted the wording slightly.. and included semantic linebreaks.
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
rfratto
added
variant/flow
|
Hi 👋 Thank you for the work on this. Is this PR expected to be merged in grafana/agent or grafana/alloy ? |
|
I'll need to switch the destination branch to be of |
hainenber
deleted the
support-for-user-configuration-of-pyroscope-scrape-seconds-query-params
branch
github-actions
bot
added
the
frozen-due-to-age
PR Description
Which issue(s) this PR fixes
Fixes grafana/alloy#195
Notes to the Reviewer
PR Checklist