Make EnableProtobufNegotiation configurable to enable native histogram scraping in static mode #7057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Yu Long <yu.long@databricks.com>
|
Can I get some eyes on this PR? cc: @bcotton @rafaelroquetto since git blame shows your names :) |
|
Perhaps the wrong Bob? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add
EnableProtobufNegotiationto static config so as to enable native histogram scraping in static mode.A similar issue for flow mode has been raised in #5136 and fixed in #5335. This PR fixes it for static mode. NOTE - For static mode,
scrape_classic_histogramsis already supported so no action needed in this PR.Which issue(s) this PR fixes
Fixes #7056
Notes to the Reviewer
PR Checklist