Skip to content

Commit

Permalink
Merge pull request #75 from grafana/move-internal-tools
Browse files Browse the repository at this point in the history
Move cmd/alloy-service to internal/cmd/alloy-service
  • Loading branch information
rfratto authored Mar 25, 2024
2 parents 073c288 + a1f6730 commit e8e6707
Show file tree
Hide file tree
Showing 17 changed files with 12 additions and 65 deletions.
8 changes: 4 additions & 4 deletions .drone/pipelines/build_images.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ local secrets = import '../util/secrets.jsonnet';
local locals = {
on_merge: {
ref: ['refs/heads/main'],
paths: { include: ['build-image/**'] },
paths: { include: ['tools/build-image/**'] },
},
on_build_image_tag: {
event: ['tag'],
Expand Down Expand Up @@ -36,7 +36,7 @@ local locals = {
'docker login -u $DOCKER_LOGIN -p $DOCKER_PASSWORD',
'docker run --rm --privileged multiarch/qemu-user-static --reset -p yes',
'docker buildx create --name multiarch --driver docker-container --use',
'docker buildx build --build-arg="GO_RUNTIME=golang:1.22.1-bullseye" --push --platform linux/amd64,linux/arm64 -t grafana/agent-build-image:$IMAGE_TAG ./build-image',
'docker buildx build --build-arg="GO_RUNTIME=golang:1.22.1-bullseye" --push --platform linux/amd64,linux/arm64 -t grafana/agent-build-image:$IMAGE_TAG ./tools/build-image',
],
}],
volumes: [{
Expand All @@ -59,7 +59,7 @@ local locals = {
'docker login -u $DOCKER_LOGIN -p $DOCKER_PASSWORD',
'docker run --rm --privileged multiarch/qemu-user-static --reset -p yes',
'docker buildx create --name multiarch --driver docker-container --use',
'docker buildx build --build-arg="GO_RUNTIME=mcr.microsoft.com/oss/go/microsoft/golang:1.22.1-bullseye" --push --platform linux/amd64,linux/arm64 -t grafana/agent-build-image:$IMAGE_TAG ./build-image',
'docker buildx build --build-arg="GO_RUNTIME=mcr.microsoft.com/oss/go/microsoft/golang:1.22.1-bullseye" --push --platform linux/amd64,linux/arm64 -t grafana/agent-build-image:$IMAGE_TAG ./tools/build-image',
],
}],
volumes: [{
Expand All @@ -83,7 +83,7 @@ local locals = {
// and not by Windows (where the syntax obviously wouldn't work).
'$IMAGE_TAG="${DRONE_TAG##build-image/v}-windows"',
'docker login -u $Env:DOCKER_LOGIN -p $Env:DOCKER_PASSWORD',
'docker build -t grafana/agent-build-image:$IMAGE_TAG ./build-image/windows',
'docker build -t grafana/agent-build-image:$IMAGE_TAG ./tools/build-image/windows',
'docker push grafana/agent-build-image:$IMAGE_TAG',
],
}],
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/check-linux-build-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Check Linux build image
on:
pull_request:
paths:
- 'build-image/*'
- 'tools/build-image/*'

jobs:
check-linux-build-image:
Expand All @@ -21,7 +21,7 @@ jobs:
- name: Create test Linux build image
uses: docker/build-push-action@v5
with:
context: ./build-image
context: ./tools/build-image
push: false
tags: grafana/alloy-build-image:latest
build-args: |
Expand All @@ -30,7 +30,7 @@ jobs:
- name: Create test Linux build image for boring crypto
uses: docker/build-push-action@v5
with:
context: ./build-image
context: ./tools/build-image
push: false
tags: grafana/alloy-build-image:latest
build-args: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-windows-build-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Check Windows build image
on:
pull_request:
paths:
- 'build-image/windows/**'
- 'tools/build-image/windows/**'

jobs:
check-windows-build-image:
Expand All @@ -19,4 +19,4 @@ jobs:
tags: latest
registry: docker.io
pushImage: false
dockerfile: ./build-image/windows/Dockerfile
dockerfile: ./tools/build-image/windows/Dockerfile
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
##
## binaries Compiles all binaries.
## alloy Compiles cmd/alloy to $(ALLOY_BINARY)
## alloy-service Compiles cmd/alloy-service to $(SERVICE_BINARY)
## alloy-service Compiles internal/cmd/alloy-service to $(SERVICE_BINARY)
##
## Targets for building Docker images:
##
Expand Down Expand Up @@ -166,7 +166,7 @@ alloy-service:
ifeq ($(USE_CONTAINER),1)
$(RERUN_IN_CONTAINER)
else
$(GO_ENV) go build $(GO_FLAGS) -o $(SERVICE_BINARY) ./cmd/alloy-service
$(GO_ENV) go build $(GO_FLAGS) -o $(SERVICE_BINARY) ./internal/cmd/alloy-service
endif

alloylint:
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
1 change: 0 additions & 1 deletion internal/cmd/rivereval/example.river

This file was deleted.

52 changes: 0 additions & 52 deletions internal/cmd/rivereval/main.go

This file was deleted.

2 changes: 1 addition & 1 deletion packaging/alloy/windows/install_script.nsis
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Section "install"
Exists:
SetOutPath "$INSTDIR"

File "..\..\..\dist.temp\alloy-windows-amd64.exe"
File "..\..\..\dist\alloy-windows-amd64.exe"
File "..\..\..\dist.temp\alloy-service-windows-amd64.exe"
File "logo.ico"

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit e8e6707

Please sign in to comment.