Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a snmp_context argument to SNMP exporter #1019

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Jun 11, 2024

PR Description

Adding a snmp_context config argument which was added in the upstream repo and in Agent a few weeks ago.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@ptodev ptodev requested a review from clayton-cornell as a code owner June 11, 2024 14:28
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jun 11, 2024
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look OK

@ptodev ptodev merged commit 1ec015d into main Jun 11, 2024
18 checks passed
@ptodev ptodev deleted the ptodev/add-snmp_context branch June 11, 2024 15:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants