Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mysqld_exporter to v0.16.0 #1643

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Update mysqld_exporter to v0.16.0 #1643

merged 2 commits into from
Nov 29, 2024

Conversation

cristiangreco
Copy link
Collaborator

@cristiangreco cristiangreco commented Sep 10, 2024 •
edited
Loading

PR Description

Update to mysqld_exporter v0.16.0 and also include prometheus/mysqld_exporter#897.

Note that we continue to use the grafana/mysqld_exporter branch refactor_collector, including changes from our branch prometheus/mysqld_exporter#774.

Which issue(s) this PR fixes

n.a.

Notes to the Reviewer

This introduces the use of github.com/tjhop/slog-gokit

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch 5 times, most recently from 152acc0 to b7b1fb2 Compare September 10, 2024 15:36
@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch from b7b1fb2 to 976d501 Compare September 11, 2024 08:50
@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch 2 times, most recently from 043860e to 0f466b4 Compare September 11, 2024 15:25
@cristiangreco cristiangreco marked this pull request as ready for review September 11, 2024 15:43
@cristiangreco cristiangreco requested a review from a team as a code owner September 11, 2024 15:43
@cristiangreco cristiangreco marked this pull request as draft September 11, 2024 15:43
@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch from 0f466b4 to 40b6e18 Compare September 12, 2024 07:46
@github-actions GitHub Actions
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch 4 times, most recently from 9697e59 to bb8e29b Compare November 7, 2024 13:32
thampiotr
thampiotr reviewed Nov 7, 2024
View reviewed changes
go.mod Outdated
@@ -161,7 +161,7 @@ require (
github.com/prometheus/common/sigv4 v0.1.0
github.com/prometheus/consul_exporter v0.8.0
github.com/prometheus/memcached_exporter v0.13.0
github.com/prometheus/mysqld_exporter v0.14.0
github.com/prometheus/mysqld_exporter v0.15.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any new config options that need to be exposed since it's a minor version, it can have new features?

@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch from bb8e29b to 20cb1b5 Compare November 8, 2024 13:40
cristiangreco
cristiangreco commented Nov 8, 2024
View reviewed changes
internal/static/integrations/mysqld_exporter/mysqld-exporter.go Outdated
@@ -122,7 +123,7 @@ func New(log log.Logger, c *Config) (integrations.Integration, error) {
}

scrapers := GetScrapers(c)
exporter := collector.New(context.Background(), string(dsn), scrapers, log, collector.Config{
exporter := collector.New(context.Background(), string(dsn), scrapers, slog.Default(), collector.Config{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thampiotr New here now requires an slog.Logger, is there any adapter in the Alloy codebase?

@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch from 962ed3c to 69337c6 Compare November 11, 2024 09:21
@cristiangreco cristiangreco changed the title Update mysqld_exporter to v0.15.1 Update mysqld_exporter to v0.16.0 Nov 11, 2024
@wildum wildum mentioned this pull request Nov 13, 2024
Closed
@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch 2 times, most recently from 58f86b7 to 508bb22 Compare November 26, 2024 16:04
@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch 4 times, most recently from e509089 to 912bf13 Compare November 27, 2024 11:41
@dehaansa
Copy link
Contributor

#2173 should be resolved by this when its ready

@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch from 912bf13 to 7d01ee8 Compare November 28, 2024 09:31
cristiangreco
cristiangreco commented Nov 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@cristiangreco cristiangreco marked this pull request as ready for review November 28, 2024 09:48
cristiangreco
cristiangreco commented Nov 28, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch 4 times, most recently from cd13c30 to 34bdb8c Compare November 28, 2024 19:47
@cristiangreco
Update mysqld_exporter to v0.16.0
5b76ec2 
From grafana/mysqld_exporter branch `refactor_collector`, including
changes in prometheus/mysqld_exporter#774.
@cristiangreco cristiangreco force-pushed the cristian/mysqld-exporter-upd branch from 34bdb8c to 5b76ec2 Compare November 28, 2024 19:57
wildum
wildum approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the implementation follows the one from https://github.com/tjhop/slog-gokit/blob/main/handler.go that Mimir is using besides the necessary small changes that are needed to make it work with the Alloy internal logger

@wildum wildum merged commit 83bbc81 into main Nov 29, 2024
17 of 18 checks passed
@wildum wildum deleted the cristian/mysqld-exporter-upd branch November 29, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildum wildum wildum approved these changes

@thampiotr thampiotr Awaiting requested review from thampiotr

@andriikushch andriikushch Awaiting requested review from andriikushch

Assignees
No one assigned
Labels
needs-attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cristiangreco @dehaansa @thampiotr @andriikushch @wildum