-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
influxdb2otel receiver #1760
base: main
Are you sure you want to change the base?
influxdb2otel receiver #1760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good. Only a couple really minor suggestions.
docs/sources/reference/components/otelcol/otelcol.receiver.influxdb.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.influxdb.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.influxdb.md
Outdated
Show resolved
Hide resolved
…luxdb.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…luxdb.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…luxdb.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution :) I left a few comments.
The config converter is also missing, have a look at this PR as example:
docs/sources/reference/components/otelcol/otelcol.receiver.influxdb.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.influxdb.md
Outdated
Show resolved
Hide resolved
go.mod
Outdated
@@ -813,9 +813,21 @@ require ( | |||
) | |||
|
|||
require ( | |||
github.com/influxdata/influxdb-client-go/v2 v2.14.0 | |||
github.com/influxdata/influxdb1-client v0.0.0-20220302092344-a9ab5670611c | |||
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/influxdbreceiver v0.108.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be better to put the requirement next to the other otel components requirements to keep them grouped
PR Description
Influx receiver that converts to OTEL
Can be used in conjunction with
otelcol.exporter.prometheus
to further convert influx to prom format.ex alloy config:
Notes to the Reviewer
plz let me know if issue or something missing with my pr - cheers :)
PR Checklist