Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows_exporter to v0.27.3 #1785

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Update windows_exporter to v0.27.3 #1785

merged 2 commits into from
Sep 30, 2024

Conversation

jkroepke
Copy link
Contributor

PR Description

Fixes #1744

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@jkroepke
Update windows_exporter to v0.27.3
1d73237 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
Update windows_exporter to v0.27.3
5b5e2ca 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke requested a review from a team as a code owner September 28, 2024 08:52
@wildum wildum merged commit 65b9f44 into grafana:main Sep 30, 2024
15 checks passed
@jkroepke jkroepke deleted the fix-panic-windows-exporter branch September 30, 2024 08:13
@lukaszch
Copy link

Hi, is this fix going to be released soon as 1.4.2?
After installing 1.4.1, Alloy service on Windows crashes constantly with an error message:

runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x72b8d33]

goroutine 816 [running]:
github.com/prometheus-community/windows_exporter/pkg/collector/service.(*Collector).Collect(0xc001e5e500, 0x0?, 0x0?)
	/go/pkg/mod/github.com/prometheus-community/windows_exporter@v0.27.2/pkg/collector/service/service.go:152 +0x33
github.com/prometheus-community/windows_exporter/pkg/collector.(*Prometheus).execute(0xc001dade40, {0x9f0368f, 0x7}, {0xb5e2528, 0xc001e5e500}, 0xc002916ca0, 0xc005caeba0)
	/go/pkg/mod/github.com/prometheus-community/windows_exporter@v0.27.2/pkg/collector/prometheus.go:176 +0x8f
github.com/prometheus-community/windows_exporter/pkg/collector.(*Prometheus).Collect.func2({0x9f0368f, 0x7}, {0xb5e2528?, 0xc001e5e500?})
	/go/pkg/mod/github.com/prometheus-community/windows_exporter@v0.27.2/pkg/collector/prometheus.go:117 +0xa5
created by github.com/prometheus-community/windows_exporter/pkg/collector.(*Prometheus).Collect in goroutine 807
	/go/pkg/mod/github.com/prometheus-community/windows_exporter@v0.27.2/pkg/collector/prometheus.go:115 +0x470

Thank you.

erikbaranowski pushed a commit that referenced this pull request Sep 30, 2024
@jkroepke @erikbaranowski
Update windows_exporter to v0.27.3 (#1785)
cd3119f 
* Update windows_exporter to v0.27.3

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

* Update windows_exporter to v0.27.3

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

---------

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
(cherry picked from commit 65b9f44)
@wildum
Copy link
Contributor

wildum commented Oct 1, 2024

@lukaszch we are planning a patch release containing this bugfix for the end of the week

ptodev pushed a commit that referenced this pull request Oct 4, 2024
@jkroepke @ptodev
Update windows_exporter to v0.27.3 (#1785)
c8af2f5 
* Update windows_exporter to v0.27.3

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

* Update windows_exporter to v0.27.3

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

---------

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
ptodev added a commit that referenced this pull request Oct 4, 2024
@ptodev @morremeyer
@jkroepke @dependabot @cydergoth @thampiotr @mattdurham
[release/v1.4] Prepare for 1.4.2 - cherry pick changes and update VER…
f59e491 
…SION file (#1828)

* chore: bump yet-another-cloudwatch-exporter to v0.61.0 (#1690)

* chore: bump yet-another-cloudwatch-exporter to v0.61.0

This bumps yet-another-cloudwatch-exporter to v0.61.0, which fixes [an issue with S3 metrics being reported as `NaN`](prometheus-community/yet-another-cloudwatch-exporter#728).

Affected metrics have a value of `0` in the scraped prometheus metrics. With the update to v0.61.0, they are reported correctly.

* fixup! chore: bump yet-another-cloudwatch-exporter to v0.61.0

JobLevelMetricFields has been removed with prometheus-community/yet-another-cloudwatch-exporter#1412

* fixup! chore: bump yet-another-cloudwatch-exporter to v0.61.0

* Update windows_exporter to v0.27.3 (#1785)

* Update windows_exporter to v0.27.3

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

* Update windows_exporter to v0.27.3

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

---------

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

* build(deps): bump webpack from 5.82.1 to 5.94.0 in /internal/web/ui (#1594)

Bumps [webpack](https://github.com/webpack/webpack) from 5.82.1 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.82.1...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump rollup from 2.79.1 to 2.79.2 in /internal/web/ui (#1775)

Bumps [rollup](https://github.com/rollup/rollup) from 2.79.1 to 2.79.2.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.79.1...v2.79.2)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 1687 otelcol.exporter.awss3 config fixes (#1791)

* Address loki.process config reloads (#1809)

* Fix logs cluster (#1716)

* fix clustering for logs

* Simplify code.

* Add changelog.

* Reorder changelog

* Update VERSION

---------

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: morre <mmeyer@anaconda.com>
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: cydergoth <cydergoth@gmail.com>
Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>
Co-authored-by: mattdurham <mattdurham@ppog.org>
@RABCbot
Copy link

RABCbot commented Oct 7, 2024

Just installed 1.4.2 and getting same error

runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x74a8d33]

@jkroepke
Copy link
Contributor Author

jkroepke commented Oct 7, 2024

@RABCbot could you please post the full stracktrace?

@RABCbot
Copy link

RABCbot commented Oct 7, 2024 •
edited
Loading

runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x74a8d33]

goroutine 812 [running]:
github.com/prometheus-community/windows_exporter/pkg/collector/service.(*Collector).Collect(0xc001e16b40, 0x0?, 0x0?)
/go/pkg/mod/github.com/prometheus-community/windows_exporter@v0.27.2/pkg/collector/service/service.go:152 +0x33
github.com/prometheus-community/windows_exporter/pkg/collector.(*Prometheus).execute(0xc001d85640, {0xa0f368f, 0x7}, {0xb7d2528, 0xc001e16b40}, 0xc0030eace8, 0xc002c4baa0)
/go/pkg/mod/github.com/prometheus-community/windows_exporter@v0.27.2/pkg/collector/prometheus.go:176 +0x8f
github.com/prometheus-community/windows_exporter/pkg/collector.(*Prometheus).Collect.func2({0xa0f368f, 0x7}, {0xb7d2528?, 0xc001e16b40?})
/go/pkg/mod/github.com/prometheus-community/windows_exporter@v0.27.2/pkg/collector/prometheus.go:117 +0xa5
created by github.com/prometheus-community/windows_exporter/pkg/collector.(*Prometheus).Collect in goroutine 805
/go/pkg/mod/github.com/prometheus-community/windows_exporter@v0.27.2/pkg/collector/prometheus.go:115 +0x470

@jkroepke
Copy link
Contributor Author

jkroepke commented Oct 7, 2024

The stack you post does not match to the lines in v0.27.3.

The stacktrace indicate that v0.27.2 is still in used.

I guess you may hit this bug: #565, where the installer does not replaced the alloy binaries. Try to install 1.4.2 again.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikbaranowski erikbaranowski erikbaranowski approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scraping Windows service info crashes Alloy
5 participants
@jkroepke @lukaszch @wildum @RABCbot @erikbaranowski