Add DisplayVersion to Windows UninstallKey #1847
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wildum
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
lgtm, ping windows expert @mattdurham @jkroepke, any concerns about this?
windows exporter is using MSI installer which brings that out of the box. No idea here. |
|
One day we will switch to MSI, likely makes things better. This feels reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds the DisplayVersion value to the uninstallation-string of the Windows NSIS installer.
The DisplayVersion can be used as a comparison operator for patch management in enterprise environments.
PR Checklist