Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenShift docs #1861

Closed
wants to merge 6 commits into from
Closed

Add OpenShift docs #1861

wants to merge 6 commits into from

Conversation

clayton-cornell
Copy link
Contributor

PR Description

This PR adds OpenShift deployment instructions to the Alloy docs

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Oct 9, 2024
@clayton-cornell clayton-cornell requested a review from lanez November 1, 2024 20:05
@clayton-cornell
Copy link
Contributor Author

@Toure If you have a chance, can you take a look through this draft and let me know if it looks OK... is it missing anything?

@clayton-cornell clayton-cornell marked this pull request as ready for review November 19, 2024 20:58
clayton-cornell and others added 3 commits November 20, 2024 10:35
Co-authored-by: Toure Dunnon <tdunnon@gmail.com>
Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left the suggestion for the configs, LGTM if that's applied. Thanks!

docs/sources/set-up/install/openshift.md Outdated Show resolved Hide resolved
Copy link

@Toure Toure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayton-cornell I left a couple suggestions.

docs/sources/set-up/install/openshift.md Show resolved Hide resolved
docs/sources/set-up/install/openshift.md Show resolved Hide resolved
docs/sources/set-up/install/openshift.md Show resolved Hide resolved
docs/sources/set-up/install/openshift.md Show resolved Hide resolved
docs/sources/set-up/install/openshift.md Show resolved Hide resolved
docs/sources/set-up/install/openshift.md Show resolved Hide resolved
docs/sources/set-up/install/openshift.md Show resolved Hide resolved
docs/sources/set-up/install/openshift.md Show resolved Hide resolved
@clayton-cornell
Copy link
Contributor Author

clayton-cornell commented Dec 11, 2024

This PR has build issues that are a pain to fix. The new PR is #2265

Open comments and feedback/suggestions will be ported over to the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.5 type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants