-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixin: Add alloy cluster label filters to dashboards #2018
base: main
Are you sure you want to change the base?
Conversation
@wildum WDYT about this? I have noticed you have only included this label to the |
else | ||
||| | ||
label_values(prometheus_remote_storage_sent_batch_duration_seconds_sum{%(filterSelector)s, job="$job", instance=~"$instance", component_id=~"$component"}, url) | ||
||| % $._config, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this branching is not scaling very well. If we add another variable it will just look awful. Isn't there a way to make this simpler? I'm not familiar with the dashboards config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will consult @v-zhuravlev on this, since he is a jsonnet sorcerer.
@wildum any comments regarding the including of |
Could we instead recommend that if users have two or more Alloy clusters, then it's important to make them have a different I think that would be cleaner then having an ever-increasing list of labels to group by. |
There is currently no way to support it on integrations, unfortunately. The standard we apply for all integrations is a static We currently use this static job label to correlate logs and metrics, and collect usage data to point ARR. |
Honestly besides the cluster label I do not see we adding any new one. |
PR Description
This is including the new
cluster_name
label introduced here to all dashboards.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist