Fix static converters

CHANGELOG.md

@@ -61,6 +61,8 @@ Main (unreleased)
 
 - Fixed an issue where the `otelcol.processor.interval` could not be used because the debug metrics were not set to default. (@wildum)
 
+- Fix conversion of static config to Alloy for `discovery.azure` and `otelcol.exporter.prometheus`. (@wildum) 
+
 ### Other changes
 
 - Change the stability of the `livedebugging` feature from "experimental" to "generally available". (@wildum)

internal/converter/internal/prometheusconvert/component/azure.go

@@ -25,19 +25,27 @@ func toDiscoveryAzure(sdConfig *prom_azure.SDConfig) *azure.Arguments {
 		return nil
 	}
 
-	return &azure.Arguments{
+	args := &azure.Arguments{
 		Environment:     sdConfig.Environment,
 		Port:            sdConfig.Port,
 		SubscriptionID:  sdConfig.SubscriptionID,
-		OAuth:           toDiscoveryAzureOauth2(sdConfig.ClientID, sdConfig.TenantID, string(sdConfig.ClientSecret)),
-		ManagedIdentity: toManagedIdentity(sdConfig),
 		RefreshInterval: time.Duration(sdConfig.RefreshInterval),
 		ResourceGroup:   sdConfig.ResourceGroup,
 		ProxyConfig:     common.ToProxyConfig(sdConfig.HTTPClientConfig.ProxyConfig),
 		FollowRedirects: sdConfig.HTTPClientConfig.FollowRedirects,
 		EnableHTTP2:     sdConfig.HTTPClientConfig.EnableHTTP2,
 		TLSConfig:       *common.ToTLSConfig(&sdConfig.HTTPClientConfig.TLSConfig),
 	}
+
+	// Only one auth method is allowed.
+	switch sdConfig.AuthenticationMethod {
+	case "ManagedIdentity":
+		args.ManagedIdentity = toManagedIdentity(sdConfig)
+	default:
+		args.OAuth = toDiscoveryAzureOauth2(sdConfig.ClientID, sdConfig.TenantID, string(sdConfig.ClientSecret))
+	}
+
+	return args
 }
 
 func ValidateDiscoveryAzure(sdConfig *prom_azure.SDConfig) diag.Diagnostics {

internal/converter/internal/prometheusconvert/testdata/azure.alloy

@@ -6,21 +6,11 @@ discovery.azure "prometheus1" {
 		tenant_id     = "tenant"
 		client_secret = "secret"
 	}
-
-	managed_identity {
-		client_id = "client"
-	}
 }
 
 discovery.azure "prometheus2" {
 	subscription_id = "subscription"
 
-	oauth {
-		client_id     = "client"
-		tenant_id     = "tenant"
-		client_secret = "secret"
-	}
-
 	managed_identity {
 		client_id = "client"
 	}

internal/converter/internal/prometheusconvert/testdata/azure.yaml

@@ -15,6 +15,7 @@ scrape_configs:
         client_secret: "secret"
         proxy_url: "proxy"
         follow_redirects: false
+        authentication_method: "ManagedIdentity"
 
 remote_write:
   - name: "remote1"

internal/converter/internal/prometheusconvert/testdata/discovery.alloy

@@ -6,10 +6,6 @@ discovery.azure "prometheus1" {
 		tenant_id     = "tenant1"
 		client_secret = "secret1"
 	}
-
-	managed_identity {
-		client_id = "client1"
-	}
 }
 
 discovery.azure "prometheus1_2" {
@@ -20,10 +16,6 @@ discovery.azure "prometheus1_2" {
 		tenant_id     = "tenant2"
 		client_secret = "secret2"
 	}
-
-	managed_identity {
-		client_id = "client2"
-	}
 }
 
 discovery.relabel "prometheus1" {

internal/converter/internal/prometheusconvert/testdata/discovery_relabel.alloy

@@ -6,10 +6,6 @@ discovery.azure "prometheus2" {
 		tenant_id     = "tenant"
 		client_secret = "secret"
 	}
-
-	managed_identity {
-		client_id = "client"
-	}
 }
 
 discovery.relabel "prometheus1" {

internal/converter/internal/promtailconvert/testdata/azure.alloy

@@ -6,10 +6,6 @@ discovery.azure "fun" {
 		tenant_id     = "tenant"
 		client_secret = "secret"
 	}
-
-	managed_identity {
-		client_id = "client"
-	}
 }
 
 local.file_match "fun" {

internal/converter/internal/staticconvert/testdata/prom_scrape.alloy

@@ -6,10 +6,6 @@ discovery.azure "metrics_agent_promobee" {
 		tenant_id     = "tenant"
 		client_secret = "secret"
 	}
-
-	managed_identity {
-		client_id = "client"
-	}
 	proxy_url = "proxy"
 }
 
@@ -21,10 +17,6 @@ discovery.azure "metrics_agent_promobee_2" {
 		tenant_id     = "tenant"
 		client_secret = "secret"
 	}
-
-	managed_identity {
-		client_id = "client"
-	}
 	proxy_url = "proxy"
 }
 

internal/converter/internal/staticconvert/testdata/traces.alloy

@@ -52,10 +52,6 @@ discovery.azure "_0_default_prometheus1" {
 		tenant_id     = "tenant1"
 		client_secret = "secret1"
 	}
-
-	managed_identity {
-		client_id = "client1"
-	}
 }
 
 discovery.lightsail "_0_default_prometheus1" {
@@ -118,7 +114,7 @@ prometheus.relabel "_0_default" {
 }
 
 otelcol.exporter.prometheus "_0_default" {
-	gc_frequency = "0s"
+	gc_frequency = "15m0s"
 	forward_to   = [prometheus.relabel._0_default.receiver]
 }
 
@@ -204,7 +200,7 @@ prometheus.relabel "_1_default" {
 }
 
 otelcol.exporter.prometheus "_1_default" {
-	gc_frequency = "0s"
+	gc_frequency = "15m0s"
 	forward_to   = [prometheus.relabel._1_default.receiver]
 }
 

internal/converter/internal/test_common/testing.go

@@ -3,6 +3,7 @@ package test_common
 import (
 	"bufio"
 	"bytes"
+	"context"
 	"fmt"
 	"io/fs"
 	"os"
@@ -12,6 +13,7 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/grafana/alloy/internal/component"
 	"github.com/grafana/alloy/internal/converter/diag"
 	"github.com/grafana/alloy/internal/featuregate"
 	alloy_runtime "github.com/grafana/alloy/internal/runtime"
@@ -20,6 +22,7 @@ import (
 	cluster_service "github.com/grafana/alloy/internal/service/cluster"
 	http_service "github.com/grafana/alloy/internal/service/http"
 	"github.com/grafana/alloy/internal/service/labelstore"
+	"github.com/grafana/alloy/internal/service/livedebugging"
 	remotecfg_service "github.com/grafana/alloy/internal/service/remotecfg"
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/stretchr/testify/require"
@@ -214,14 +217,42 @@ func attemptLoadingAlloyConfig(t *testing.T, bb []byte) {
 			clusterService,
 			labelstore.New(nil, prometheus.DefaultRegisterer),
 			remotecfgService,
+			livedebugging.New(),
 		},
 		EnableCommunityComps: true,
 	})
 	err = f.LoadSource(cfg, nil, "")
 
+	// This is a bit of an ugly workaround but the spanmetrics connector is starting a go routine in its start function.
+	// If the goroutine is not stopped, it will result in a panic. To stop it we need to run the Alloy controller to run the component and then stop it.
+	// We cannot run the Alloy controller for all tests because some components such as the statsd_exporter will panic after being stopped and some other components have wrong config.
+	runAlloyController := false
+	components, err := f.ListComponents("", component.InfoOptions{})
+	require.NoError(t, err)
+	for _, component := range components {
+		if component.ComponentName == "otelcol.connector.spanmetrics" {
+			runAlloyController = true
+			break
+		}
+	}
+
+	if runAlloyController {
+		ctx, cancel := context.WithCancel(context.Background())
+		done := make(chan struct{})
+		go func() {
+			f.Run(ctx)
+			close(done)
+		}()
+		defer func() {
+			cancel()
+			<-done
+		}()
+	}
+
 	// Many components will fail to build as e.g. the cert files are missing, so we ignore these errors.
 	// This is not ideal, but we still validate for other potential issues.
-	if err != nil && strings.Contains(err.Error(), "Failed to build component") {
+	// Tests that require the Alloy controller to run should not have build error else the components won't run.
+	if !runAlloyController && err != nil && strings.Contains(err.Error(), "Failed to build component") {
 		t.Log("ignoring error: " + err.Error())
 		return
 	}

internal/static/traces/remotewriteexporter/factory.go

@@ -37,7 +37,10 @@ func NewFactory() exporter.Factory {
 }
 
 func createDefaultConfig() component.Config {
-	return &Config{}
+	return &Config{
+		StaleTime:    15 * time.Minute,
+		LoopInterval: time.Second,
+	}
 }
 
 func createMetricsExporter(