Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Debugging button should appear in UI only for supported components #2293

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Live Debugging button should appear in UI only for supported components #2293

merged 2 commits into from
Dec 18, 2024

Conversation

ravishankar15
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Fixes #1008

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated

@ravishankar15 ravishankar15 requested a review from a team as a code owner December 17, 2024 15:54
wildum
wildum reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work again, thanks a lot!

internal/web/ui/src/features/component/ComponentView.tsx Outdated Show resolved Hide resolved
wildum
wildum approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I will spin it locally tomorrow to see how it looks in the UI and merge it if that's fine. Thanks again!

wildum
wildum approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks!

@wildum wildum merged commit d8ba009 into grafana:main Dec 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildum wildum wildum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Live Debugging button in UI should appear only for components that supports the feature
2 participants
@ravishankar15 @wildum