Add Windows application manifest #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
rfratto
added
the
backport-to-agent:no
ptodev
approved these changes
Apr 24, 2024
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
|
While working on the boringcrypto build I don't think this actually made it to the release binary. Since the release calls Alloy which calls go build directly and bypasses the value in packaging. Its going to be a bit picky to fix to be be honest, since the manifest requires windows and I cant get generate-ui to also working within the image at the moment. |
As I thought, |
|
What might be going on is we build the windows executable in a cross compile step and for go build we pass in the GOOS and GOARCH flags for windows so it pulls down the windows executable but its actually in a Linux environment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR attaches a Windows Application Manifest to alloy and alloy service binary.
It add an icon to the binaries and enabled modern OS feature, like Windows long-path awareness and attach meta information like version of alloy.
go-winres is using git tag --describe to detect the currently git tag. It dev builds may result into mis-leadling versioning, since git tag --describe may take note of the helm chart tags as well. See tc-hib/go-winres#23
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist