Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus native histogram support to otel.receiver.prometheus #835

Merged
merged 7 commits into from
May 14, 2024

Conversation

wildum
Copy link
Contributor

@wildum wildum commented May 13, 2024

PR Description

The support was added upstream with v0.99.0 via open-telemetry/opentelemetry-collector-contrib@13fca79

Which issue(s) this PR fixes

Fixes #483

Notes to the Reviewer

First commit is a copy of the code from upstream except that we need to keep "textparse" pkg for now

PR Checklist

  • CHANGELOG.md updated
  • Tests updated
  • Use featuregate to support it only for public preview

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the question about whether this should/needs to be configurable.

Also, can we add a comment somewhere in the component describing what SHA we copied the code from, just to track it?

@wildum wildum marked this pull request as draft May 14, 2024 13:00
@wildum
Copy link
Contributor Author

wildum commented May 14, 2024

converting to draft for now to prevent accidental merge

@wildum wildum force-pushed the add-prom-native-histo-support-otel-receiver branch from 806a307 to 0704a4b Compare May 14, 2024 16:40
@wildum wildum marked this pull request as ready for review May 14, 2024 16:46
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM part two :)

@wildum wildum merged commit d252877 into main May 14, 2024
18 checks passed
@wildum wildum deleted the add-prom-native-histo-support-otel-receiver branch May 14, 2024 16:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otelcol.receiver.prometheus: add support for native Prometheus histograms
2 participants