-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus native histogram support to otel.receiver.prometheus #835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending the question about whether this should/needs to be configurable.
Also, can we add a comment somewhere in the component describing what SHA we copied the code from, just to track it?
converting to draft for now to prevent accidental merge |
806a307
to
0704a4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM part two :)
PR Description
The support was added upstream with v0.99.0 via open-telemetry/opentelemetry-collector-contrib@13fca79
Which issue(s) this PR fixes
Fixes #483
Notes to the Reviewer
First commit is a copy of the code from upstream except that we need to keep "textparse" pkg for now
PR Checklist