Update Loki and sync some of the Promtail code #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the Loki stages straight copies of the promtail changes? |
As far as I remember, they're not, there are some changes to the constructor etc, but they are functionally equivalent and relatively easy to map between each other. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bug fixes were made in Promtail recently:
I think both of these fixes only really impact static mode, but I'd prefer if I update Alloy first and backport to Agent, so that Alloy is not more out of date.
For the first issue I just tested Flow mode and Alloy, and it seems like the bug is still there for them and I need to fix it separately.