Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit ECS Meta metrics even when no prometheus instrumentation #309

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Emit ECS Meta metrics even when no prometheus instrumentation #309

merged 1 commit into from
Jul 17, 2023

Conversation

jradhakrishnan
Copy link
Contributor

@jradhakrishnan jradhakrishnan commented Jul 14, 2023 •
edited
Loading

[ch16154]

  • Build StaticConfig even when no prometheus targets
  • Always emit meta metrics
  • Build scrape target only when Prometheus instrumentation is present
  • Remove unused config fields
  • Reorder methods in ECSTaskUtil based on access
  • Account level env name if present, precedes install level env name

@jradhakrishnan
Emit ECS Meta metrics even when no prometheus instrumentation
a0921b2 
[ch16154]

* Build `StaticConfig` even when no prometheus targets
* Always emit meta metrics
* Build scrape target only when Prometheus instrumentation is present
* Remove unused config fields
* Reorder methods in `ECSTaskUtil` based on access
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #16154: Emit ECS Meta metrics even when no Prometheus Scrape Targets.

@jradhakrishnan jradhakrishnan merged commit 080da4d into main Jul 17, 2023
4 checks passed
@jradhakrishnan jradhakrishnan deleted the radha/sc-16154 branch July 17, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandadev nandadev nandadev approved these changes

@shanavazh shanavazh Awaiting requested review from shanavazh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jradhakrishnan @nandadev