Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v0.8.0 #218

Closed
wants to merge 2 commits into from
Closed

chore: release v0.8.0 #218

wants to merge 2 commits into from

Conversation

sd2k
Copy link
Collaborator

@sd2k sd2k commented Dec 23, 2024

πŸ€– New release

  • augurs: 0.7.0 -> 0.8.0 (βœ“ API compatible changes)
  • augurs-changepoint: 0.7.0 -> 0.8.0
  • augurs-core: 0.7.0 -> 0.8.0 (⚠️ API breaking changes)
  • augurs-clustering: 0.7.0 -> 0.8.0
  • augurs-dtw: 0.7.0 -> 0.8.0
  • augurs-ets: 0.7.0 -> 0.8.0
  • augurs-mstl: 0.7.0 -> 0.8.0
  • augurs-forecaster: 0.7.0 -> 0.8.0 (⚠️ API breaking changes)
  • augurs-outlier: 0.7.0 -> 0.8.0 (βœ“ API compatible changes)
  • augurs-prophet: 0.7.0 -> 0.8.0 (βœ“ API compatible changes)
  • augurs-seasons: 0.7.0 -> 0.8.0

⚠️ augurs-core breaking changes

--- failure module_missing: pub module removed or renamed ---

Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/module_missing.ron

Failed in:
  mod augurs_core::interpolate, previously in file /tmp/.tmpCHBaSF/augurs-core/src/interpolate.rs:1

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/struct_missing.ron

Failed in:
  struct augurs_core::interpolate::Interpolate, previously in file /tmp/.tmpCHBaSF/augurs-core/src/interpolate.rs:71
  struct augurs_core::interpolate::LinearInterpolator, previously in file /tmp/.tmpCHBaSF/augurs-core/src/interpolate.rs:41

--- failure trait_missing: pub trait removed or renamed ---

Description:
A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/trait_missing.ron

Failed in:
  trait augurs_core::interpolate::InterpolateExt, previously in file /tmp/.tmpCHBaSF/augurs-core/src/interpolate.rs:159
  trait augurs_core::interpolate::Interpolater, previously in file /tmp/.tmpCHBaSF/augurs-core/src/interpolate.rs:16
  trait augurs_core::interpolate::Interpolatable, previously in file /tmp/.tmpCHBaSF/augurs-core/src/interpolate.rs:198

⚠️ augurs-forecaster breaking changes

--- failure auto_trait_impl_removed: auto trait no longer implemented ---

Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
        ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/auto_trait_impl_removed.ron

Failed in:
  type Forecaster is no longer UnwindSafe, in /tmp/.tmpVw2rWo/augurs/crates/augurs-forecaster/src/forecaster.rs:12
  type Forecaster is no longer RefUnwindSafe, in /tmp/.tmpVw2rWo/augurs/crates/augurs-forecaster/src/forecaster.rs:12

--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_missing.ron

Failed in:
  enum augurs_forecaster::transforms::Transform, previously in file /tmp/.tmpCHBaSF/augurs-forecaster/src/transforms.rs:37
  enum augurs_forecaster::Transform, previously in file /tmp/.tmpCHBaSF/augurs-forecaster/src/transforms.rs:37

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_added.ron

Failed in:
  variant Error:Transform in /tmp/.tmpVw2rWo/augurs/crates/augurs-forecaster/src/error.rs:26

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/inherent_method_missing.ron

Failed in:
  Forecaster::with_transforms, previously in file /tmp/.tmpCHBaSF/augurs-forecaster/src/forecaster.rs:34

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/struct_missing.ron

Failed in:
  struct augurs_forecaster::transforms::MinMaxScaleParams, previously in file /tmp/.tmpCHBaSF/augurs-forecaster/src/transforms.rs:131
Changelog

augurs

0.8.0 - 2024-12-23

Added

augurs-changepoint

0.7.0 - 2024-11-25

Other

  • update Cargo.toml dependencies

augurs-core

0.8.0 - 2024-12-23

Added

augurs-clustering

0.5.2 - 2024-10-25

Other

  • add benchmark for Prophet (#140)

augurs-dtw

0.6.0 - 2024-11-08

Added

  • [breaking] split JS package into separate crates (#149)

augurs-ets

0.7.0 - 2024-11-25

Other

  • update Cargo.toml dependencies

augurs-mstl

0.7.0 - 2024-11-25

Other

  • update Cargo.toml dependencies

augurs-forecaster

0.8.0 - 2024-12-23

Added

Fixed

Other

augurs-outlier

0.8.0 - 2024-12-23

Other

augurs-prophet

0.8.0 - 2024-12-23

Added

Fixed

Other

augurs-seasons

0.7.0 - 2024-11-25

Other

  • update Cargo.toml dependencies


This PR was generated with release-plz.

Summary by CodeRabbit

  • New Features

    • Introduced a breaking change where the transform functionality has been switched to a trait.
    • Added the ability to create Box-Cox or Yeo-Johnson transforms.
    • Introduced a standard scaler transform and a new 'transforms' JavaScript crate.
    • Added a "Forecaster" wrapper for the Prophet library.
  • Bug Fixes

    • Corrected the usage of box_cox instead of boxcox.
    • Made the Transform enum non-exhaustive.
  • Documentation

    • Updated changelogs for version 0.8.0 across multiple components.
    • Fixed an incorrect link to the chrono library in documentation.
  • Chores

    • Updated dependency versions for several components to ensure alignment with version 0.8.0.

Copy link
Contributor

coderabbitai bot commented Dec 23, 2024

Walkthrough

This pull request focuses on version updates across the Augurs project workspace. The primary change involves incrementing the workspace and all related dependencies from version 0.7.0 to 0.8.0. Multiple changelog files have been updated to reflect this version bump, with specific notes about breaking changes, particularly around the transform functionality being switched to a trait. The update spans multiple crates including augurs-core, augurs-forecaster, augurs-outlier, augurs-prophet, and the main augurs workspace.

Changes

File Changes
Cargo.toml Workspace version updated from 0.7.0 to 0.8.0; All dependencies (augurs-*) version bumped to 0.8.0
crates/augurs-core/CHANGELOG.md Added 0.8.0 version entry with breaking change for transform functionality
crates/augurs-forecaster/CHANGELOG.md Added 0.8.0 version entry with multiple features, fixes, and structural changes
crates/augurs-outlier/CHANGELOG.md Added 0.8.0 version entry with rv dependency update
crates/augurs-prophet/CHANGELOG.md Added 0.8.0 version entry with new features and dependency updates
crates/augurs/CHANGELOG.md Added 0.8.0 version entry referencing breaking change in transform functionality

Possibly related PRs

Poem

🐰 Hop, hop, version bump we go!
From 0.7 to 0.8, watch us grow
Transforms now a trait so neat
Changelog updates, our changes complete
Augurs leaps forward with glee! πŸš€


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 8ed69b7 and e1ae551.

πŸ“’ Files selected for processing (6)
  • Cargo.toml (2 hunks)
  • crates/augurs-core/CHANGELOG.md (1 hunks)
  • crates/augurs-forecaster/CHANGELOG.md (1 hunks)
  • crates/augurs-outlier/CHANGELOG.md (1 hunks)
  • crates/augurs-prophet/CHANGELOG.md (1 hunks)
  • crates/augurs/CHANGELOG.md (1 hunks)
βœ… Files skipped from review due to trivial changes (1)
  • crates/augurs-outlier/CHANGELOG.md
πŸ”‡ Additional comments (7)
crates/augurs/CHANGELOG.md (1)

10-14: Verify breaking change documentation

The breaking change is properly documented with the correct version bump and [breaking] tag. However, given the PR objectives mention multiple breaking changes in augurs-core and augurs-forecaster, consider adding more details about other breaking changes.

Consider expanding the changelog entry to include:

  • Specific modules/structs/traits that were removed or renamed
  • Impact on downstream code
  • Migration guide or upgrade instructions
βœ… Verification successful

Let me gather information about the breaking changes by examining the codebase.


Let me search for more specific information about the breaking changes and the transform trait.


Based on the code analysis, I can now generate the final response:

Breaking changes properly documented, no additional changes needed

The switch of transform to a trait is the only breaking change in this release. The code shows this is a significant architectural change affecting the transformation system, where various transformers like MinMaxScaler, StandardScaler, BoxCox, YeoJohnson, etc. implement the Transformer trait. This change is correctly marked as breaking and the version bump from 0.7.0 to 0.8.0 follows semver.

The PR objectives mentioning multiple breaking changes in augurs-core and augurs-forecaster appear to be referring to this same transformation system change, as the transformation functionality is a core feature used across these crates. No additional breaking changes were found that would need separate documentation.

🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found


Script:

#!/bin/bash
# Check PR description and commits for breaking change details
gh pr view --json title,body

# Look for transform trait implementation and related changes
ast-grep --pattern 'trait Transform'

# Search for other potential breaking changes in the codebase
rg -l "BREAKING" -g "!CHANGELOG.md"

# Check for any migration guides or upgrade instructions
fd README.md

Length of output: 733


Script:

#!/bin/bash
# Look for transform-related changes in Rust files
rg -A 5 "transform" -t rust

# Check commit messages in the relevant crates
fd Cargo.toml -t f -x cat {} | grep -A 1 "name.*augurs"

# Search for any upgrade or migration documentation
rg -i "upgrade|migration" -g "*.md"

# Look for any trait definitions and implementations
ast-grep --pattern 'impl Transform for $_'

Length of output: 74509

Cargo.toml (1)

21-21: Version updates are consistent

The workspace version and all augurs-* dependencies have been correctly updated to 0.8.0, maintaining consistency across the workspace.

Let's verify that all crates in the workspace have corresponding version updates:

Also applies to: 32-41

βœ… Verification successful

Version updates are consistent across the workspace

The verification confirms that all version references in the workspace are correctly set to 0.8.0:

  • Workspace version is set to 0.8.0 in workspace.package
  • All augurs-* dependencies in workspace.dependencies are consistently versioned at 0.8.0
  • All package manifests inherit the workspace version through version.workspace = true
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify version consistency across workspace crates

# Check versions in all Cargo.toml files
echo "Checking versions in Cargo.toml files:"
fd Cargo.toml crates/ -x rg -l "version\s*=\s*\"0\.8\.0\""

# Check for any remaining 0.7.0 versions that might have been missed
echo -e "\nChecking for any remaining 0.7.0 versions:"
fd Cargo.toml crates/ -x rg -l "version\s*=\s*\"0\.7\.0\""

Length of output: 305


Script:

#!/bin/bash
# Let's try a different approach to check versions in Cargo.toml files

# First, let's find all Cargo.toml files and check their content
echo "=== Checking all version fields in Cargo.toml files ==="
fd Cargo.toml --type f -x cat {}

# Also check the workspace Cargo.toml
echo -e "\n=== Checking workspace Cargo.toml ==="
cat Cargo.toml

Length of output: 28017

crates/augurs-forecaster/CHANGELOG.md (1)

9-27: Comprehensive changelog with well-documented changes

The changelog properly documents the breaking changes, improvements, and fixes. The changes are well-categorized and align with the PR objectives.

Let's verify the referenced PRs are merged and the changes are included:

βœ… Verification successful

Let me verify the transform trait changes to ensure the changelog accurately reflects the codebase changes.


Changelog entries accurately reflect the codebase changes

The verification confirms:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify referenced PRs and changes

# Check if referenced PRs are merged
for pr in 213 212 204 195 203 194 210 196 185; do
  echo "Checking PR #$pr:"
  gh pr view $pr --json state,mergedAt
done

# Verify transform-related changes
echo -e "\nVerifying transform-related changes:"
rg -l "trait\s+Transform" crates/augurs-forecaster/src/

Length of output: 1854


Script:

#!/bin/bash
# Check transform trait implementation and module structure
echo "Transform trait definition:"
rg -A 10 "trait\s+Transform" crates/augurs-forecaster/src/

echo -e "\nTransform modules structure:"
fd . crates/augurs-forecaster/src/transforms/

echo -e "\nBox-Cox and Yeo-Johnson implementations:"
rg -l "Box.*Cox|Yeo.*Johnson" crates/augurs-forecaster/src/

Length of output: 1712

crates/augurs-core/CHANGELOG.md (2)

9-10: LGTM! Version entry follows the standard format

The version entry correctly follows the Keep a Changelog format with:

  • Proper version number (0.8.0)
  • Correct date format (2024-12-23)
  • Valid GitHub comparison link

13-13: Enhance breaking change documentation

The breaking change entry "switch transform to a trait" should include:

  • Migration guide for users
  • List of removed/renamed public types
  • Code examples showing how to update existing code

Let's check for any existing documentation about this breaking change:

crates/augurs-prophet/CHANGELOG.md (2)

10-11: LGTM! Version entry follows the standard format

The version entry correctly follows the Keep a Changelog format with:

  • Proper version number (0.8.0)
  • Correct date format (2024-12-23)
  • Valid GitHub comparison link

23-23: Document potential breaking changes from wasmtime update

The update of wasmtime from version 27 to 28 might introduce breaking changes. Consider:

  • Adding [breaking] tag if there are API changes
  • Documenting any required code changes
  • Including migration steps if needed

Let's check the wasmtime changelog for breaking changes:

βœ… Verification successful

Let me check how wasmtime is used in the codebase to understand the impact of these changes.


Let me check the specific wasmtime features being used to understand if they're affected by the breaking changes.


No breaking changes impact detected - update is safe

After reviewing the wasmtime v28.0.0 changelog and the codebase usage, the update appears safe as:

  • No breaking API changes affect the used features (Component, Linker, Engine, Store)
  • Changes are mostly additions and internal improvements
  • Memory-related changes don't impact the current usage
  • The code uses stable public APIs that remain unchanged
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if wasmtime update introduces breaking changes
gh api repos/bytecodealliance/wasmtime/releases | jq -r '.[] | select(.tag_name == "v28.0.0") | .body'

Length of output: 3927


Script:

#!/bin/bash
# Search for wasmtime usage patterns
rg -A 3 "use wasmtime::" 

Length of output: 496


Script:

#!/bin/bash
# Check the content of the file using wasmtime
cat crates/augurs-prophet/src/wasmstan.rs

Length of output: 9594


### Added

- add Forecaster wrapper for Prophet (#191)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codebase verification

Documentation needs improvement for the Forecaster wrapper

Based on the verification results, while there is a working example in examples/forecasting/examples/prophet_forecaster.rs and some API documentation in the source code, the Forecaster wrapper functionality needs better documentation:

  • The main README focuses on the Prophet model but doesn't mention the Forecaster wrapper
  • The implementation has inline documentation but lacks comprehensive usage guidelines
  • Key features like transformation capabilities are only shown in examples

Suggested documentation additions:

  • Add a dedicated section in README.md about the Forecaster wrapper
  • Document integration with the augurs framework
  • Explain the transformation pipeline capabilities
  • Provide clear examples of prediction interval generation
πŸ”— Analysis chain

Document the Forecaster wrapper functionality

The addition of the Forecaster wrapper for Prophet should include:

  • Basic usage examples
  • Key features and capabilities
  • Integration guidelines

Let's check for existing documentation:


Let me check the example and documentation content in more detail:


Let me check if there's any additional documentation in the README or other documentation files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for Forecaster wrapper documentation
rg -g '!target' -g '*.{md,rs}' -i 'forecaster.*wrapper|prophet.*forecaster'

Length of output: 2234


Script:

#!/bin/bash
# Check the example content
cat examples/forecasting/examples/prophet_forecaster.rs

# Check the implementation documentation
cat crates/augurs-prophet/src/forecaster.rs

Length of output: 8989


Script:

#!/bin/bash
# Check README and other potential documentation
cat crates/augurs-prophet/README.md 2>/dev/null || true
cat crates/augurs-prophet/src/lib.rs 2>/dev/null || true

Length of output: 9016

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between e1ae551 and 0fbdc50.

πŸ“’ Files selected for processing (3)
  • crates/augurs-forecaster/CHANGELOG.md (1 hunks)
  • crates/augurs-prophet/CHANGELOG.md (1 hunks)
  • crates/augurs/CHANGELOG.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • crates/augurs-prophet/CHANGELOG.md
  • crates/augurs-forecaster/CHANGELOG.md
πŸ”‡ Additional comments (2)
crates/augurs/CHANGELOG.md (2)

10-11: LGTM! Version and date format are correct.

The version link and release date follow the Keep a Changelog format correctly.


12-13: Verify the migration guide link accessibility.

While the breaking changes notice is good, let's ensure the migration guide link is accessible.

βœ… Verification successful

Let me verify the content of the migration guide to ensure it contains the specific section mentioned in the link (#from-07-to-08).


Migration guide link is valid and contains the referenced section

The migration guide exists at book/src/migrating.md and includes a detailed "From 0.7 to 0.8" section that properly documents the breaking changes mentioned in the changelog.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the migration guide link exists and is accessible
# Expected: Find the migration guide markdown file in the docs directory

fd -g "*migrating*" -t f

Length of output: 48


Script:

#!/bin/bash
# Check if the migration guide contains the section for 0.7 to 0.8 migration
cat book/src/migrating.md

Length of output: 4837

Comment on lines +14 to +16
### Added

- [**breaking**] switch `transform` to a trait (#213)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ› οΈ Refactor suggestion

Document all breaking changes mentioned in PR objectives.

The changelog only mentions the transform trait change, but the PR objectives indicate additional breaking changes in augurs-core and augurs-forecaster, including removal/renaming of public modules, structs, traits, and enums.

Add these breaking changes to maintain a comprehensive changelog:

 ### Added
 
 - [**breaking**] switch `transform` to a trait (#213)
+
+### Removed
+
+- [**breaking**] removed/renamed public modules in augurs-core
+- [**breaking**] removed/renamed structs, traits, and enums in augurs-forecaster
πŸ“ Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### Added
- [**breaking**] switch `transform` to a trait (#213)
### Added
- [**breaking**] switch `transform` to a trait (#213)
### Removed
- [**breaking**] removed/renamed public modules in augurs-core
- [**breaking**] removed/renamed structs, traits, and enums in augurs-forecaster

@sd2k sd2k closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant