Add seasonality detection using periodograms, and Python/JS bindings #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd2k
force-pushed
the
seasonal-detection
branch
from
f485605 to
b35fe58
Compare
sd2k
force-pushed
the
seasonal-detection
branch
from
3279e9d to
ad13458
Compare
sd2k
force-pushed
the
seasonal-detection
branch
from
ad13458 to
74791f0
Compare
This means detectors don't need to store the data and can avoid a lifetime parameter.
sd2k
force-pushed
the
seasonal-detection
branch
from
31d6dfb to
30d7ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
augurs-seasonscrate which implements similar behaviour to theseasonalPython package, specifically detecting the season length of a time series using periodograms. The implementation differs slightly due to differences between the implementations of the underlying Welch method, so I'm not 100% confident in how well it will work, and I'm leaving this marked as 'alpha' in the README for now.