Cleanup UID/InstanceID duplicity. Also remove override_instance_id
config option
#1125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
UID
andInstance
fields in thesvc.ID
allowed users to override the instance ID. This was created as a troubleshooting feature that would only work when the Beyla instance instrumented a single application instance (sidecar mode).This feature adds some complexity to the code, but still has remained unused (both because we haven't required to troubleshoot instance IDs, and because Beyla usually instruments multiple instances, so using this feature would break the instrumentation).
Removing the duplicity, and the overriding feature, fixes one of the two described duplicities in the issue #1124
After this is merged, the simpler code would facilitate removing the other duplicity from the aforementioned issue.