Fix instance and job in prometheus, and document honor_labels #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
requested review from
grcevski,
marctc and
rafaelroquetto
as code owners
mariomac
force-pushed
the
rename-target-instance
branch
2 times, most recently
from
d62eb1f
to
53a7930
Compare
marctc
approved these changes
Sep 4, 2024
mariomac
force-pushed
the
rename-target-instance
branch
from
53a7930
to
aced4f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
+ Coverage 81.96% 82.05% +0.08%
==========================================
Files 141 141
Lines 11586 11588 +2
==========================================
+ Hits 9496 9508 +12
+ Misses 1564 1557 -7
+ Partials 526 523 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming
target_instancePrometheus toinstance. Also thejobattribute has been added to Prometheus.Now, all the metrics are consistent, no matter they are exported via OTEL or Prometheus.