-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for RHEL 4.18 kernels #1175
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
==========================================
- Coverage 81.16% 81.13% -0.03%
==========================================
Files 136 136
Lines 11447 11451 +4
==========================================
Hits 9291 9291
- Misses 1630 1634 +4
Partials 526 526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, few lines you fixed this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great stuff @rafaelroquetto!
a96dcc5
to
8b31176
Compare
This syscall is not present in older kernels
Co-authored-by: Sean Packham <sean.packham@grafana.com>
8b31176
to
6af03dd
Compare
Relax the minimum supported version and tweak a few tests to allow Beyla to run on RHEL 4.8 kernel series.
From the package description:
(source)
These are the kernels whose version is analogous to 4.18.0-xxx.el8 and they feature the functionality required by Beyla, included but not limited to:
Early RHEL 4.18 kernels (such as 4.18.0-240.el8) do not yet feature BPF ring buffers and are not supported.
These kernels do not support
BEYLA_BPF_TRACK_REQUEST_HEADERS=1
.Tested on:
Resolves #1146