Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable batching for traces #1352

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Enable batching for traces #1352

merged 4 commits into from
Nov 15, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Nov 12, 2024

This PR re-enables support for batching in traces. It uses the experimental API for batching introduced recently
This is the issue to track the progress: open-telemetry/opentelemetry-collector#8122

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (5998c47) to head (4f59fa7).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/export/otel/traces.go 70.58% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   72.09%   80.76%   +8.66%     
==========================================
  Files         144      145       +1     
  Lines       14586    14653      +67     
==========================================
+ Hits        10516    11834    +1318     
+ Misses       3373     2236    -1137     
+ Partials      697      583     -114     
Flag Coverage Δ
integration-test 58.90% <70.58%> (-0.11%) ⬇️
k8s-integration-test 59.30% <52.94%> (-0.01%) ⬇️
oats-test 34.41% <47.05%> (+0.01%) ⬆️
unittests 52.01% <47.05%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marctc marctc marked this pull request as ready for review November 14, 2024 14:22
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marctc marctc merged commit 15310ef into main Nov 15, 2024
13 checks passed
@marctc marctc deleted the batching_config branch November 15, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants