Add support for pod matching based on labels #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
===========================================
- Coverage 76.86% 33.52% -43.34%
===========================================
Files 97 124 +27
Lines 8008 9288 +1280
===========================================
- Hits 6155 3114 -3041
- Misses 1512 5995 +4483
+ Partials 341 179 -162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
reviewed
Mar 25, 2024
grafsean
requested changes
Mar 25, 2024
msvechla
force-pushed
the
label_selector
branch
from
0f97fa5 to
94a5660
Compare
mariomac
approved these changes
Mar 25, 2024
This change adds a new selector property `k8s_pod_labels` to the services configuration. This selector property will limit the instrumentation to the applications running in the Pods having labels with keys matching the provided value as regular expression.
msvechla
force-pushed
the
label_selector
branch
from
94a5660 to
18e8cc4
Compare
grafsean
approved these changes
Mar 25, 2024
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
* Add support for pod matching based on labels This change adds a new selector property `k8s_pod_labels` to the services configuration. This selector property will limit the instrumentation to the applications running in the Pods having labels with keys matching the provided value as regular expression. * lint: rename Env var to Environment variable as recommended by Vale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new selector property
k8s_pod_labelsto the services configuration. This selector property will limit the instrumentation to the applications running in the Pods having labels with matching keys and values.Addresses #691
Please let me know what you think and whether we can improve the implementation.