Add option for direct Beyla spanmetric generation #731
Conversation
pkg/internal/export/otel/metrics.go
Outdated
| @@ -46,6 +50,7 @@ const ( | |||
|
|
|||
| FeatureNetwork = "network" | |||
| FeatureApplication = "application" | |||
| FeatureSpan = "span" | |||
There was a problem hiding this comment.
Being picky here. Isn't "span" a subset of "application" feature?
There was a problem hiding this comment.
I think you are right :), what should I call it? Maybe trace_span_metrics? Technically the application now is application_otel the new one is application_trace_span_metrics.
There was a problem hiding this comment.
Looking at it twice, I think it's fine just span or application_span.
There was a problem hiding this comment.
I like application_span a lot, thanks for the suggestion. It will remove confusion from the network metrics.
|
From the current integration test failure, it seems I have two choices, implement this for Prometheus scraping or limit the tests to not run this path when we Prom scape. I'm leaning towards adjusting the tests, because without pushing OTel metrics and directly scraping from Beyla, I think we may not get the needed labels (like, job and instance) which are required for proper visualization. |
Adds configuration option to generate span metrics directly from Beyla, allowing tools which use span metrics for visualization to consume data directly from Beyla.
Span graphs will be done through separate PR
TODO: