Add instrumentation for sql.Exec
#733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 76.04% 69.09% -6.95%
==========================================
Files 105 128 +23
Lines 8527 9746 +1219
==========================================
+ Hits 6484 6734 +250
- Misses 1683 2628 +945
- Partials 360 384 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
grcevski
reviewed
Apr 11, 2024
| @@ -39,7 +39,8 @@ func main() { | |||
| if len(urlQuery["query"]) > 0 { | |||
| queryString := urlQuery["query"][0] | |||
| fmt.Println("query arg in url query is:", queryString) | |||
| rows, e = db.Query(queryString) | |||
| //rows, e = db.Query(queryString) | |||
| _, e = db.Exec(queryString) | |||
There was a problem hiding this comment.
I think you probably want to check if the query doesn't start with 'SELECT' and run db.Query if it's 'SELECT'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing instrumentation for
database/sqlpackage forsql.Exec