Document attributes selection and filtering features #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
commented
May 16, 2024
| The architecture below shows the different components of Beyla. | ||
| The dashed boxes in the diagram below can be enabled and disabled according to the configuration. | ||
|
|
||
|  |
There was a problem hiding this comment.
This figure was outdated and the current picture is way more complex. It would show architectural implementation details that might not be useful for our final users.
mariomac
commented
May 16, 2024
| @@ -753,25 +790,19 @@ attacks. This option should be used only for testing and development purposes. | |||
|
|
|||
| Configures the intervening time between exports. | |||
|
|
|||
| | YAML | Environment variable | Type | Default | | |||
| | --------------- | ----------------------------- | ------- | ------- | | |||
| | `report_target` | `BEYLA_METRICS_REPORT_TARGET` | boolean | `false` | | |||
There was a problem hiding this comment.
report_target and report_peer are still supported but they became deprecate with the new attributes selection feature. That's why I removed the documentation.
grafsean
approved these changes
May 20, 2024
|
LGTM! Note for later, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.