Dashboards: defined container functions for common resources panels #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Jun 18, 2021
pracucci
approved these changes
Jun 22, 2021
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ | |||
| * [ENHANCEMENT] cortex-mixin: Make `cluster_namespace_deployment:kube_pod_container_resource_requests_{cpu_cores,memory_bytes}:sum` backwards compatible with `kube-state-metrics` v2.0.0. #317 | |||
| * [BUGFIX] Fixed `CortexIngesterHasNotShippedBlocks` alert false positive in case an ingester instance had ingested samples in the past, then no traffic was received for a long period and then it started receiving samples again. #308 | |||
| * [BUGFIX] Alertmanager: fixed `--alertmanager.cluster.peers` CLI flag passed to alertmanager when HA is enabled. #329 | |||
| * [CHANGE] Dashboards: defined container functions for common resources panels: containerDiskWritesPanel, containerDiskReadsPanel, containerDiskSpaceUtilization. #331 | |||
There was a problem hiding this comment.
A CHANGE is a breaking change for the final user. This PR can be considered an ENHANCEMENT. Also we need to keep CHANGELOG entries sorted by type (CHANGE, FEATURE, ENHANCEMENT, BUGFIX).
Suggested change
| * [CHANGE] Dashboards: defined container functions for common resources panels: containerDiskWritesPanel, containerDiskReadsPanel, containerDiskSpaceUtilization. #331 | |
| * [ENHANCEMENT] Dashboards: defined container functions for common resources panels: containerDiskWritesPanel, containerDiskReadsPanel, containerDiskSpaceUtilization. #331 |
added: - containerDiskWritesPanel - containerDiskReadsPanel - containerDiskSpaceUtilization
darrenjaneczek
force-pushed
the
darrenjaneczek/resources-dashboards-container-functions
branch
from
3de040c to
e5a38db
Compare
pracucci
deleted the
darrenjaneczek/resources-dashboards-container-functions
branch
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…czek/resources-dashboards-container-functions Dashboards: defined container functions for common resources panels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Dashboards: defined (overridable) container functions for common resources panels:
Added whitespace for readability of some related queries.
Verified that the generated dashboard results match, so long as the following following pattern replacement is made:
'\\n\s*'to''Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]