Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboards to support Helm chart deployment #427

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

danfromtitan
Copy link

What this PR does:

Update cortex-mixin to support Helm chart deployment and produce usable dashboards. List of issues fixed by this change:

  • support disabling cortex-gw, query scheduler and ruler panels
  • generalize instance names to also match Helm chart deployments
  • remove cluster from namespace matcher to cope with metrics outside Cortex service that don't have a cluster label
  • fix disk panels to display correct written byte metrics
  • support custom Prometheus http prefix
  • display read/write metrics from Cortex distributor/querier instead of cortex-gw
  • rearrange panels in rollout dashboard to make better sense of the metrics shown

Caveat:

  • I tested dashboards with Helm chart deployments but since that uses opensource Cortex image I could not test the dashboards when cortex-gw component is enabled.

Which issue(s) this PR fixes:
Fixes #361

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@jmcarp
Copy link

jmcarp commented Mar 23, 2022

Do you all have capacity to review this @pracucci? Would be useful for my team as well.

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dan Constantinescu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dealing with mostly broken Grafana dashboards
3 participants