add the ability to specify the basic auth user #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubicgruenfeld
force-pushed
the
add-basic-auth-user
branch
from
3390492 to
19fd3f9
Compare
gotjosh
reviewed
May 28, 2021
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
|
Thanks for reviewing that fast! :) |
|
Thank you @kubicgruenfeld ! Lastly, can you please create a changelog entry under https://github.com/grafana/cortex-tools/blob/main/CHANGELOG.md#unreleasedmaster? |
gotjosh
approved these changes
May 28, 2021
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Jan 12, 2022
) * add the ability to specify the basic auth user * also add user to alertmanager command * Update README.md Co-authored-by: gotjosh <josue.abreu@gmail.com> * Update pkg/alerting/runner.go Co-authored-by: gotjosh <josue.abreu@gmail.com> * Update pkg/commands/alerts.go Co-authored-by: gotjosh <josue.abreu@gmail.com> * Update pkg/commands/alerts.go Co-authored-by: gotjosh <josue.abreu@gmail.com> * Update pkg/commands/alerts.go Co-authored-by: gotjosh <josue.abreu@gmail.com> * Update pkg/commands/rules.go Co-authored-by: gotjosh <josue.abreu@gmail.com> * Update pkg/commands/rules.go Co-authored-by: gotjosh <josue.abreu@gmail.com> * Update pkg/commands/alerts.go Co-authored-by: gotjosh <josue.abreu@gmail.com> * add changelog entry Co-authored-by: gotjosh <josue.abreu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to specify the basic auth user explicitly instead of assume the id is the username for authentication.
This fixes #186.