Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycler: Categorize advanced configuration parameters #129

Merged
merged 2 commits into from
Feb 1, 2022
Merged

lifecycler: Categorize advanced configuration parameters #129

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a4032
lifecycler: Categorize advanced configuration parameters
simonswine Feb 1, 2022
a26670f
Also mark ReadinessCheckRingHealth as advanced
simonswine Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ring/lifecycler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@ type LifecyclerConfig struct {
RingConfig Config `yaml:"ring"`

// Config for the ingester lifecycle control
NumTokens int `yaml:"num_tokens"`
HeartbeatPeriod time.Duration `yaml:"heartbeat_period"`
ObservePeriod time.Duration `yaml:"observe_period"`
JoinAfter time.Duration `yaml:"join_after"`
MinReadyDuration time.Duration `yaml:"min_ready_duration"`
NumTokens int `yaml:"num_tokens" category:"advanced"`
HeartbeatPeriod time.Duration `yaml:"heartbeat_period" category:"advanced"`
ObservePeriod time.Duration `yaml:"observe_period" category:"advanced"`
JoinAfter time.Duration `yaml:"join_after" category:"advanced"`
MinReadyDuration time.Duration `yaml:"min_ready_duration" category:"advanced"`
InfNames []string `yaml:"interface_names"`

// FinalSleep's default value can be overridden by
// setting it before calling RegisterFlags or RegisterFlagsWithPrefix.
FinalSleep time.Duration `yaml:"final_sleep"`
FinalSleep time.Duration `yaml:"final_sleep" category:"advanced"`
TokensFilePath string `yaml:"tokens_file_path"`
Zone string `yaml:"availability_zone"`
UnregisterOnShutdown bool `yaml:"unregister_on_shutdown"`
UnregisterOnShutdown bool `yaml:"unregister_on_shutdown" category:"advanced"`
ReadinessCheckRingHealth bool `yaml:"readiness_check_ring_health"`
simonswine marked this conversation as resolved.
Show resolved Hide resolved

// For testing, you can override the address and ID of this ingester
Expand Down