Remove unused metrics exported by ring lifecycler and client #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
FWIW I used to watch the ring ownership when doing an ingester rollout back when it handed-off tokens from a leaving ingester to a joining one. But now we replace ingesters in-place and retain the same tokens it doesn't seem very interesting. |
bboreham
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR proposes to remove some metrics exported by ring client and lifecycler. This proposed change originates from a discussion we had in grafana/mimir#1750 about some high cardinality metrics exposed by large Mimir clusters (running hundreds of instances).
In this PR I propose to remove the following metrics, which don't look to be much useful:
member_ring_tokens_owned: actual number of tokens (ring virtual nodes) registered by the ring lifecycler (e.g. 128)member_ring_tokens_to_own: configured number of tokens (ring virtual nodes) in the ring lifecycler (e.g. 128)ring_tokens_owned: exposes how many tokens (ring virtual nodes) that member has registered in the ring (e.g. 128)ring_member_ownership_percent: exposes the % of tokens owned in the ring (exposed by web UI too)I checked Mimir / Loki / Tempo mixins and I can't find any reference of these metrics.
Which issue(s) this PR fixes:
Part of grafana/mimir#1750
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]