Add GetWithRF() method to DynamicReplicationReadRing interface #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly created DynamicReplicationReadRing interfaces extends the ReadRing interface with the new function that allows for getting instances of the ring based on the provided replication factor, where in contrast the existing Get() function used the globally configured replication factor. The new function allows for example for per-tenant replication factors. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
6 tasks
chaudum
added a commit
to grafana/loki
that referenced
this pull request
May 31, 2023
Pulls changes from grafana/dskit#304 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
commented
May 31, 2023
| @@ -46,6 +46,7 @@ | |||
| * [CHANGE] Cache: Remove the `context.Context` argument from the `Cache.Store` method and rename the method to `Cache.StoreAsync`. #273 | |||
| * [FEATURE] Cache: Add support for configuring a Redis cache backend. #268 #271 #276 | |||
| * [FEATURE] Add support for waiting on the rate limiter using the new `WaitN` method. #279 | |||
| * [ENHANCEMENT] Add `GetWithRF()` function to DynamicReplicationReadRing interface. #304 | |||
There was a problem hiding this comment.
Feature or Enhancement?
chaudum
added a commit
to grafana/loki
that referenced
this pull request
Jun 1, 2023
Pulls changes from grafana/dskit#304 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The newly created DynamicReplicationReadRing interfaces extends the ReadRing interface with the new function that allows for getting instances of the ring based on the provided replication factor, where in contrast the existing Get() function used the globally configured replication factor.
The new function allows for example for per-tenant replication factors.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]