Reduce duplication introduced in weaveworks/common migration #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
reviewed
Aug 11, 2023
|
|
||
| ErrNoUserID = errors.Error("no user id") | ||
| ErrDifferentUserIDPresent = errors.Error("different user ID already present") | ||
| ErrTooManyUserIDs = errors.Error("multiple user IDs present") |
There was a problem hiding this comment.
Should this error be dropped? Why?
There was a problem hiding this comment.
It's not used anywhere.
There was a problem hiding this comment.
OK thanks for clarifying.
aknuds1
approved these changes
Aug 11, 2023
charleskorn
deleted the
charleskorn/weaveworks-common-to-dskit-migration-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes two instances of unnecessary duplication introduced in #342:
github.com/grafana/dskit/errorsis removed in favour of Go'serrorsgithub.com/grafana/dskit/grpcutil.IsGRPCContextCanceled()is removed in favour ofIsCanceledin the same package.As far as I can see, the first change has only minor impact outside this repository, and
grpcutil.IsGRPCContextCanceled()is used in a single test in Mimir where the minor difference in behaviour is harmless.Which issue(s) this PR fixes:
Fixes #343
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]