Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how read-only fields display in ring HTML page #587

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

pr00se
Copy link
Contributor

@pr00se pr00se commented Sep 25, 2024

What this PR does:

When dealing with a ring status page with hundreds of instances, it can be difficult to tell which ones are currently read-only. This PR makes two changes:

  • for instances that are not read-only, leave the Read-Only field in the status page empty, rather than showing false
  • for instances that are read-only, also show the duration that they have been read-only in the Read-Only Updated field

Before:
Screenshot 2024-09-25 at 2 44 52 AM

After:
Screenshot 2024-09-25 at 2 56 16 AM

Which issue(s) this PR fixes:

Fixes #N/A

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pr00se pr00se merged commit 7c41a40 into main Sep 25, 2024
5 checks passed
@pr00se pr00se deleted the read-only-ring-page branch September 25, 2024 19:36
@pr00se pr00se changed the title Change how read-only fields disaply in ring HTML page Change how read-only fields display in ring HTML page Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants