Replace exp/slices with slices from standard library
#626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The experimental functions in `golang.org/x/exp/slices` are now available in the standard library in Go 1.21 [1]. [1]: https://go.dev/doc/go1.21#slices Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
|
|
Juneezee
commented
Dec 16, 2024
| func New[E constraints.Ordered](lists [][]E, maxVal E) *Tree[E] { | ||
| func New[E cmp.Ordered](lists [][]E, maxVal E) *Tree[E] { |
There was a problem hiding this comment.
The constraints.Ordered from golang.org/x/exp/constraints is also included into Go 1.21 as cmp.Ordered. See https://pkg.go.dev/cmp#Ordered
aknuds1
reviewed
Dec 16, 2024
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
dskit/ring/token_range.go
Line 7 in e27df29
We upgraded the minimum Go version to 1.21 in PR #540.
The experimental functions in
golang.org/x/exp/slicesare now included in the standard library since Go 1.21.Reference: https://go.dev/doc/go1.21#slices
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]