Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default values for server.throughput.unit #635

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

tinitiuset
Copy link
Contributor

What this PR does:

Based on comment grafana/mimir#10103 (review) this change is intended for consistency. Changes default value from total_samples to samples_processed.

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no one is relying on this value, so it's ok to change 👍

@tinitiuset tinitiuset merged commit 441a90a into main Jan 7, 2025
5 checks passed
@tinitiuset tinitiuset deleted the tinitiuset/update-throughput-default-unit branch January 7, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants