Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the closer package since it's trivial #70

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

56quarters
Copy link
Contributor

The only uses found were the Consul mock kv client. Even in
Cortex/Loki/Tempo the only uses were the vendored version of
the same Consul mock kv client.

Fixes #51

Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

The only uses found were the Consul mock kv client. Even in
Cortex/Loki/Tempo the only uses were the vendored version of
the same Consul mock kv client.

Fixes #51

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@56quarters 56quarters merged commit 72fa100 into main Nov 3, 2021
@56quarters 56quarters deleted the kill-closer branch November 3, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'closer' package is too small; remove it
3 participants