Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ConsoleInstrumentation): Provide config option to send log messages for console.error calls #731

Merged
merged 8 commits into from
Nov 14, 2024
Merged

refactor(ConsoleInstrumentation): Provide config option to send log messages for console.error calls #731

merged 8 commits into from
Nov 14, 2024

Conversation

codecapitano
Copy link
Collaborator

@codecapitano codecapitano commented Nov 11, 2024 •
edited
Loading

Why

Some users want to send log signals instead of errors for console.error messages.

What

  • add config option to choose to send logs instead of errors
  • Move ConsoleInstrumentation config to Faro config and deprecate the old config.
    • Note: we do support both for now
  • Update the Faro documentation to reflect the changes

Links

Checklist

  • Tests added
  • Changelog updated
  • Documentation updated

@codecapitano codecapitano changed the title improvement(ConsoleInstrumentation): Provide config option to send log messages for console.error calls refactor(ConsoleInstrumentation): Provide config option to send log messages for console.error calls Nov 11, 2024
@codecapitano codecapitano self-assigned this Nov 11, 2024
@codecapitano codecapitano added the improvement Request a change of an existing feature label Nov 11, 2024
kpelelis
kpelelis approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@kpelelis kpelelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some inline comments

packages/core/src/config/types.ts Show resolved Hide resolved
packages/web-sdk/src/instrumentations/console/instrumentation.test.ts Show resolved Hide resolved
packages/web-sdk/src/config/makeCoreConfig.ts Show resolved Hide resolved
@codecapitano codecapitano force-pushed the enable-to-choose-to-send-logs-for-console.error-messages branch 2 times, most recently from cc2f78c to 34b49d9 Compare November 13, 2024 15:54
@codecapitano codecapitano force-pushed the enable-to-choose-to-send-logs-for-console.error-messages branch from 34b49d9 to 559a8fc Compare November 13, 2024 16:54
@codecapitano codecapitano merged commit f70c473 into main Nov 14, 2024
4 checks passed
@codecapitano codecapitano deleted the enable-to-choose-to-send-logs-for-console.error-messages branch November 14, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpelelis kpelelis kpelelis approved these changes

@cedricziel cedricziel Awaiting requested review from cedricziel

@eskirk eskirk Awaiting requested review from eskirk

@rrmf rrmf Awaiting requested review from rrmf

Assignees

@codecapitano codecapitano

Labels
improvement Request a change of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codecapitano @kpelelis