Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kgo: do not reuse decompression buffer for uncompressed batches #8

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ortuman
Copy link
Collaborator

@ortuman ortuman commented Oct 9, 2024

This PR adds the necessary changes to avoid reusing decompression buffers when consuming uncompressed batches.

(following suggestion in twmb#823 (comment))

Copy link

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

ref: twmb#823 (comment)

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
@ortuman ortuman force-pushed the ortuman/do-not-reuse-uncompressed-buffer-slices branch from e5d5347 to 8562b71 Compare October 9, 2024 08:49
@ortuman ortuman merged commit 782ba14 into master Oct 9, 2024
1 check passed
ortuman added a commit that referenced this pull request Oct 9, 2024
ref: twmb#823 (comment)

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ortuman added a commit that referenced this pull request Oct 9, 2024
)

ref: twmb#823 (comment)

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
@ortuman ortuman deleted the ortuman/do-not-reuse-uncompressed-buffer-slices branch October 17, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants