-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration tests]: manually get the current commit for the action when bootstrapping the project. #405
Conversation
…n bootstrapping the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IfSentient Looks like using git
to get commit rev won't work, but we could get that info from the env vars – https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables.
IIUC GITHUB_SHA
should fit the bill.
I tried that before, and I get the error
It looks like 9bb57268ee194cd7cfa69a892ec20d1293134cef exists, but is some kind of fake commit that is the totality of the PR instead of being a commit in the branch or in main, which I suspect is why |
…o PR workflow to check that it will work right for release workflow.
This PR does two things:
main
,pr
, andrelease
workflows.replace
directive in thego.mod
, as usingGITHUB_SHA
doesn't cooperate withgo get
in PR builds).Currently, the branch protection settings for
main
require that an action namedtest
complete successfully to merge (which no longer exists the same way, so this blocks indefinitely), once this PR is approved I will update the branch protection settings to requiretest / unit-test
,test / integration-test
, andtest / build
instead, then merge this PR so other PR's will need to merge in from main to get correct testing.