allow project local generate to work with no kinds defined #461
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafydd-t
force-pushed
the
allow-no-kinds
branch
from
6f7a7dd
to
ffd00ea
Compare
radiohead
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: I wanted to adopt the grafana-app-sdk tooling and structure for an existing plugin because we have plans to introduce some custom Kinds there. However, in the spirit of smaller changes, I wanted to restructure the project without adding custom Kinds. You can see my example here.
This PR shows what I needed to be able to make use of
grafana-app-sdk project local generatewhen I didn't have any custom kinds defined.I couldn't see a nice way to refactor the cue generator to gracefully handle the lack of a cue module (and it didn't feel right), so I added this
noneformat which indicates that we don't have any kinds defined.Happy to be guided on this, I mainly made this PR as a discussion point. But I'd love to be able to have this functionality.