SQL Autocomplete: Support schema in table identifiers #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
requested review from
dprokop,
kevinwcyu,
sarahzinger and
scottlepp
and removed request for
dprokop and
kevinwcyu
dprokop
reviewed
Jul 22, 2022
Comment on lines
109
to
124
| { | ||
| id: StatementPosition.AfterSchema, | ||
| name: StatementPosition.AfterSchema, | ||
| resolve: (currentToken, previousKeyword, previousNonWhiteSpace, previousIsSlash) => { | ||
| // depending on weather the schema was the last token in the query or not, current token might be whitespace or dot. if whitespace, just use the previous token | ||
| if (currentToken?.isWhiteSpace() && currentToken?.next) { | ||
| currentToken = currentToken?.previous; | ||
| previousNonWhiteSpace = currentToken?.getPreviousNonWhiteSpaceToken(); | ||
| } | ||
| return Boolean( | ||
| currentToken?.isIdentifier() && | ||
| currentToken?.value.endsWith('.') && | ||
| previousNonWhiteSpace?.value.toLowerCase() === FROM | ||
| ); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
From the BigQuey pov, where you query like SELECT * from 'project.dataset.id', this will cause the after schema suggestions to kick in.
|
@dprokop @zoltanbedi back from vaction now. :) Made some changes so that this will work also with bigquery. See proposed changes in the bigquery plugin here |
This was referenced Aug 16, 2022
zoltanbedi
approved these changes
Aug 16, 2022
src/sql-editor/standardSql/statementPositionResolversRegistry.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
This was referenced Nov 3, 2022
SandersAaronD
pushed a commit
that referenced
this pull request
Jan 10, 2024
SQL Autocomplete: Support schema in table identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most SQL languages support prefixing the table name with a schema name. For example
select * from dbo.products. This allows more sophisticated autocompletion. Currently, when a schema is specified the autocompletion engine doesn't take it into account. This is breaking suggestions for columns and causing other problems where the position detection is lost.This PR adds support for rich autocompletion in the case a schema is provided in the query. To enable this, I had to change the signature for the
tablesand thecolumnsapi in the completion item provider so that it no longer only passes the table name, but also the schema. This is a breaking change that needs to be handled in for example the big query data source.Next step could be to add an api for loading schemas so that they can be suggested too.