Render: Fix panel titles should not be focused when rendering #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We just need to test it |
|
Any suggestions on how to test it @marefr? You know better than me how to look for eventual bugs from this change. |
|
@aknuds1 you can test referenced issue by creating a panel which have a panel link and use v1.0.10 to reproduce. Then checkout this branch and build a local plugin version or docker image and verify it resolves the issue. Please let me know if you would like me to do it. |
marefr
approved these changes
Mar 19, 2020
marefr
changed the title
marefr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a call to the mouse.move function so the mouse is in the bottom right corner of the viewport instead of the top left corner.
It allows to not have the "mouse:hover" style on titles while rendering panels.
I've tested several calls to the render function and it seems not to have any other impact.
Fixes #111