Add self-contained setup for load test #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
reviewed
Aug 30, 2021
pianohacker
force-pushed
the
pianohacker/load-test-self-contained-setup
branch
from
46e9db4
to
1bc0237
Compare
AgnesToulet
approved these changes
Sep 1, 2021
Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>
AgnesToulet
reviewed
Sep 6, 2021
AgnesToulet
reviewed
Sep 6, 2021
AgnesToulet
reviewed
Sep 6, 2021
| loadimpact/k6:master run \ | ||
| --vus $vus \ | ||
| --duration $duration \ | ||
| $iterationsOption \ |
There was a problem hiding this comment.
Suggested change
| $iterationsOption \ | |
| --iterations $iterations \ |
There was a problem hiding this comment.
I think this would cause the script to fail if $iterations is not specified. And you want the ability to leave the option out entirely, so you can do things like "run as many iterations as possible over 5 minutes".
There was a problem hiding this comment.
Ah yes you're right! OK, then, I guess you can merge 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create needed org, datasource, and dashboard automatically.